[LTP] [PATCH] lib: tst_bool_expr: Add support for strings

[Cyril Hrubis]

Hi!
> I suppose it depends how much later and how such an error would look. If
> the error will happen directly after leaving this function then I don't
> think it matters either, but if it is possible that it manages to
> complete the whole evaluation process before failing with TCONF because
> the vars don't match then this has the potential to waste some time.

Well I can easily add this kind of check here, however out of all
possible mistakes that you can do with misplaced quotes this would only
catch the cases where the number of quotes is odd. I.e. only a subset of
all possible errors, everything else would be caught later on when we
attempt to evaluate the expression.

E.g.

	CONFIG_FOO"=val"
	"CONFIG_FOO=val & CONFIG_BAR"
	"CONFIG_FOO"
	etc.

are all valid in this context, but completely wrong when evaluated.

I guess that it would make more sense to check if variable token is sane
in the upper layer, i.e. in the kconfig parser since we do have the full
information about how it should look like there. And this check would
also cover this case as well.

-- 
Cyril Hrubis
chrubis@suse.cz