[LTP] [PATCH 2/2] loop: Fix occasional uevent drop
Petr Vorel
pvorel@suse.cz
Thu Nov 12 20:25:40 CET 2020
Hi Christoph,
> From: Petr Vorel <pvorel@suse.cz>
Thanks for rebasing my code. Using loop.c specific code in the file instead of
the function is indeed much better.
I also like your cleanup for 5.11 (remove the update_bdev parameter from
set_capacity_revalidate_and_notify).
> Commit 716ad0986cbd ("loop: Switch to set_capacity_revalidate_and_notify")
> causes an occasional drop of loop device uevent, which are no longer
> triggered in loop_set_size() but in a different part of code.
> Bug is reproducible with LTP test uevent01 [1]:
> i=0; while true; do
> i=$((i+1)); echo "== $i =="
> lsmod |grep -q loop && rmmod -f loop
> ./uevent01 || break
> done
> Put back triggering through code called in loop_set_size().
> Fix required to add yet another parameter to
> set_capacity_revalidate_and_notify().
This ^ is no longer true and should be removed.
Kind regards,
Petr
More information about the ltp
mailing list