[LTP] [PATCH v2 09/10] syscalls/ipc: Add shmctl IPC_SET test

Cyril Hrubis chrubis@suse.cz
Tue Sep 8 08:58:16 CEST 2020


Hi!
> > diff --git a/testcases/kernel/syscalls/ipc/shmctl/shmctl07.c b/testcases/kernel/syscalls/ipc/shmctl/shmctl07.c
> > index 409203db7..39b9ad78a 100644
> > --- a/testcases/kernel/syscalls/ipc/shmctl/shmctl07.c
> > +++ b/testcases/kernel/syscalls/ipc/shmctl/shmctl07.c
> > @@ -42,10 +42,12 @@ static void verify_shmlock(void)
> >   	else
> >   		tst_res(TPASS, "shmctl(%i, SHM_UNLOCK, NULL)", shm_id);
> >   
> > +	SAFE_SHMCTL(shm_id, IPC_STAT, &ds);
> > +
> >   	if (ds.shm_perm.mode & SHM_LOCKED)
> > -		tst_res(TPASS, "SHM_LOCKED bit is off in shm_perm.mode");
> > -	else
> >   		tst_res(TFAIL, "SMH_LOCKED bit is on in shm_perm.mode");
> > +	else
> > +		tst_res(TPASS, "SHM_LOCKED bit is off in shm_perm.mode");
> >   }
> >   
> This change should belong to "syscalls/ipc: Add shmctl07 test" patch.

My bad I messed up, will fix that later on.

Anything else I missed there?

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list