[LTP] [PATCH 1/1] fanotify10: Treat ignore mask bug as TCONF for < v5.9
Cyril Hrubis
chrubis@suse.cz
Thu Sep 10 17:30:35 CEST 2020
Hi!
> if (ret > 0) {
> - tst_res(TFAIL, "group %d (%x) with %s and "
> - "%s ignore mask got event",
> + tst_res((tst_kvercmp(5, 9, 0)) < 0 ? TCONF : TFAIL,
> + "group %d (%x) with %s and %s ignore mask got event",
> i, fanotify_class[p], mark->name, ignore_mark->name);
I do not like that much, how the tst_kvercmp() is sandwitched inside of
the tst_res() call, since it makes it easier to be overlooked.
The question is how can we do better, maybe set a variable in test
setup?
Other than that it looks fine.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list