[LTP] [PATCH 00/16] syscalls: Use common variants structure

[Viresh Kumar]

On 11-09-20, 15:47, Cyril Hrubis wrote:
> Hi!
> > > --- a/include/time64_variants.h
> > > +++ b/include/time64_variants.h
> > > @@ -7,10 +7,13 @@
> > >  #ifndef TIME64_VARIANTS_H
> > >  #define TIME64_VARIANTS_H
> > >  
> > > +#ifdef HAVE_LIBAIO
> > >  #include <libaio.h>
> > > +#endif /* HAVE_LIBAIO */
> > > +
> > >  #include <signal.h>
> > >  #include <stdio.h>
> > > -#include <sys/poll.h>
> > > +#include <poll.h>
> > >  #include <time.h>
> > >  #include "tst_timer.h"
> > >  
> > > @@ -32,8 +35,12 @@ struct time64_variants {
> > >         int (*timer_settime)(kernel_timer_t timerid, int flags, void *its, void *old_its);
> > >         int (*tfd_gettime)(int fd, void *its);
> > >         int (*tfd_settime)(int fd, int flags, void *new_value, void *old_value);
> > > +
> > > +#ifdef HAVE_LIBAIO
> > >         int (*io_pgetevents)(io_context_t ctx, long min_nr, long max_nr,
> > >                         struct io_event *events, void *timeout, sigset_t *sigmask);
> > > +#endif /* HAVE_LIBAIO */
> > > +
> > >         int (*mqt_send)(mqd_t mqdes, const char *msg_ptr, size_t msg_len,
> > >                         unsigned int msg_prio, void *abs_timeout);
> > >         ssize_t (*mqt_receive)(mqd_t mqdes, char *msg_ptr, size_t msg_len,
> > 
> > And both these changes broke my build. I don't even understand how
> > could the ifdef change break it for me :(
> 
> My guess would be missing include for "config.h" in this file to get
> HAVE_LIBAIO definitions.

Right. That was it. Thanks.

Though I still get failures if I include poll.h instead of sys/poll.h
here and the errors happen only in mq_timedsend/receive tests. I am
trying to figure out why, but no clue yet.

-- 
viresh