[LTP] [PATCH] diotest4: Fix false postives on FUSE
Qian Cai
cai@redhat.com
Tue Sep 29 04:11:50 CEST 2020
It looks like FUSE does not support the unaligned IO, because it does
not directly backed by a block device. Therefore, in fuse_direct_IO(),
there is no checking of unaligned IO to return -EINVAL like other
filesystems from iomap_dio_bio_actor().
diotest4 3 TFAIL : diotest4.c:114: read allows odd count. returns 1: Success
diotest4 4 TFAIL : diotest4.c:129: write allows odd count.returns 1: Success
diotest4 5 TFAIL : diotest4.c:180: Odd count of read and write
...
diotest4 16 TFAIL : diotest4.c:114: read allows nonaligned buf. returns 4096: Success
diotest4 17 TFAIL : diotest4.c:129: write allows nonaligned buf.returns 4096: Success
diotest4 18 TFAIL : diotest4.c:180: read, write with non-aligned buffer
Signed-off-by: Qian Cai <cai@redhat.com>
---
include/tst_fs.h | 45 ++++++++++++------------
lib/tst_fs_type.c | 2 ++
testcases/kernel/io/direct_io/diotest4.c | 2 ++
3 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/include/tst_fs.h b/include/tst_fs.h
index fc0390582..a44d5e3b2 100644
--- a/include/tst_fs.h
+++ b/include/tst_fs.h
@@ -6,29 +6,30 @@
#define TST_FS_H__
/* man 2 statfs or kernel-source/include/linux/magic.h */
-#define TST_BTRFS_MAGIC 0x9123683E
-#define TST_NFS_MAGIC 0x6969
-#define TST_RAMFS_MAGIC 0x858458f6
-#define TST_TMPFS_MAGIC 0x01021994
-#define TST_V9FS_MAGIC 0x01021997
-#define TST_XFS_MAGIC 0x58465342
-#define TST_EXT2_OLD_MAGIC 0xEF51
+#define TST_BTRFS_MAGIC 0x9123683E
+#define TST_NFS_MAGIC 0x6969
+#define TST_RAMFS_MAGIC 0x858458f6
+#define TST_TMPFS_MAGIC 0x01021994
+#define TST_V9FS_MAGIC 0x01021997
+#define TST_XFS_MAGIC 0x58465342
+#define TST_EXT2_OLD_MAGIC 0xEF51
/* ext2, ext3, ext4 have the same magic number */
-#define TST_EXT234_MAGIC 0xEF53
-#define TST_MINIX_MAGIC 0x137F
-#define TST_MINIX_MAGIC2 0x138F
-#define TST_MINIX2_MAGIC 0x2468
-#define TST_MINIX2_MAGIC2 0x2478
-#define TST_MINIX3_MAGIC 0x4D5A
-#define TST_UDF_MAGIC 0x15013346
-#define TST_SYSV2_MAGIC 0x012FF7B6
-#define TST_SYSV4_MAGIC 0x012FF7B5
-#define TST_UFS_MAGIC 0x00011954
-#define TST_UFS2_MAGIC 0x19540119
-#define TST_F2FS_MAGIC 0xF2F52010
-#define TST_NILFS_MAGIC 0x3434
-#define TST_EXOFS_MAGIC 0x5DF5
-#define TST_OVERLAYFS_MAGIC 0x794c7630
+#define TST_EXT234_MAGIC 0xEF53
+#define TST_MINIX_MAGIC 0x137F
+#define TST_MINIX_MAGIC2 0x138F
+#define TST_MINIX2_MAGIC 0x2468
+#define TST_MINIX2_MAGIC2 0x2478
+#define TST_MINIX3_MAGIC 0x4D5A
+#define TST_UDF_MAGIC 0x15013346
+#define TST_SYSV2_MAGIC 0x012FF7B6
+#define TST_SYSV4_MAGIC 0x012FF7B5
+#define TST_UFS_MAGIC 0x00011954
+#define TST_UFS2_MAGIC 0x19540119
+#define TST_F2FS_MAGIC 0xF2F52010
+#define TST_NILFS_MAGIC 0x3434
+#define TST_EXOFS_MAGIC 0x5DF5
+#define TST_OVERLAYFS_MAGIC 0x794c7630
+#define TST_FUSE_SUPER_MAGIC 0x65735546
enum {
TST_BYTES = 1,
diff --git a/lib/tst_fs_type.c b/lib/tst_fs_type.c
index 1d0ac9669..21eb58a78 100644
--- a/lib/tst_fs_type.c
+++ b/lib/tst_fs_type.c
@@ -84,6 +84,8 @@ const char *tst_fs_type_name(long f_type)
return "EXOFS";
case TST_OVERLAYFS_MAGIC:
return "OVERLAYFS";
+ case TST_FUSE_SUPER_MAGIC:
+ return "FUSE"
default:
return "Unknown";
}
diff --git a/testcases/kernel/io/direct_io/diotest4.c
b/testcases/kernel/io/direct_io/diotest4.c
index bf200cd41..5f866bd93 100644
--- a/testcases/kernel/io/direct_io/diotest4.c
+++ b/testcases/kernel/io/direct_io/diotest4.c
@@ -270,6 +270,7 @@ int main(int argc, char *argv[])
switch (fs_type) {
case TST_NFS_MAGIC:
case TST_BTRFS_MAGIC:
+ case TST_FUSE_SUPER_MAGIC:
tst_resm(TCONF, "%s supports odd count IO",
tst_fs_type_name(fs_type));
break;
@@ -442,6 +443,7 @@ int main(int argc, char *argv[])
switch (fs_type) {
case TST_NFS_MAGIC:
case TST_BTRFS_MAGIC:
+ case TST_FUSE_SUPER_MAGIC:
tst_resm(TCONF, "%s supports non-aligned buffer",
tst_fs_type_name(fs_type));
break;
More information about the ltp
mailing list