[LTP] [PATCH v3 3/4] lib: Apply the skip_filesystems to rest of test as well

Cyril Hrubis chrubis@suse.cz
Tue Apr 13 13:51:29 CEST 2021


Hi!
> > +		if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
> > +			tst_brk(TCONF, "Skipping %s as requested by the test",
> > +				fs_name);
> 
> This message might be a little confusing when the test didn't ask for
> all filesystems. I'd recommend something like "Test does not support %s
> workdir, skipping". The else clause below is probably unnecessary.

I've adjusted the message to "%s is not supported by the test" and fixed
the enum name as reported by Li and pushed the patchset.

Thanks a lot for the reviews.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list