[LTP] [PATCH v4] syscalls/chown: Rewrite chown/chown03.c with the new api
Cyril Hrubis
chrubis@suse.cz
Wed Apr 21 13:58:17 CEST 2021
Hi!
> + SAFE_SETEUID(0);
> + SAFE_CHOWN(FILENAME, -1, 0);
> + SAFE_CHMOD(FILENAME, NEW_PERMS);
> + SAFE_SETEUID(ltpuser->pw_uid);
> +
> + uid_t uid;
> + gid_t gid;
> + UID16_CHECK((uid = geteuid()), "chown");
> + GID16_CHECK((gid = getegid()), "chown");
> +
> + struct stat stat_buf;
> + SAFE_STAT(FILENAME, &stat_buf);
> + check_owner(&stat_buf, uid, 0);
We should check that the S_ISUID and S_ISGID bits are set here as well.
Otherwise it looks good to me.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list