[LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk
Petr Vorel
pvorel@suse.cz
Thu Apr 29 08:52:49 CEST 2021
Hi,
> We need replace tst_res with tst_brk to terminate the test immediately since
> there is no sence to go on.
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> v2->v3: split into two separate commits
> testcases/commands/lsmod/lsmod01.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/commands/lsmod/lsmod01.sh b/testcases/commands/lsmod/lsmod01.sh
> index 2e044c718..4ed91eca5 100755
> --- a/testcases/commands/lsmod/lsmod01.sh
> +++ b/testcases/commands/lsmod/lsmod01.sh
> @@ -23,7 +23,7 @@ setup()
> tst_require_cmds insmod
> insmod "$TST_MODPATH"
> if [ $? -ne 0 ]; then
> - tst_res TBROK "insmod failed"
> + tst_brk TBROK "insmod failed"
> return
There does not need to be return (in cleanup function tst_brk just prints
warning and continues, but elsewhere it just quits).
I'll fix that during merge.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
More information about the ltp
mailing list