[LTP] [PATCH 2/2] broken_ip: TCONF when test run on unsupported protocol

[Petr Vorel]

Hi Alexey,

> Hi Petr,
> On 27.07.2021 20:35, Petr Vorel wrote:
> > Hi Alexey,

> >> On 14.07.2021 17:07, Petr Vorel wrote:
> >>> net_stress.broken_ip runtest file is correct, but some users try to run
> >>> tests manually.

> >>> Fixes: #843

> ...
> >>>  do_test()

> >> The generic version looks fine:

> >> Reviewed-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>

> > I didn't understand whether you'd prefer to add TST_IPV6=6 (or TST_IPV6=) where
> > needed or accept this patchset. Both would work.

> I think for manual runs it is better to set TST_IPV6=6 in the test
> so it will run the test rather the require passing some options.
It looks like specifying TST_IPV6=6 is not enough, because tests are using
$NS_ICMP_SENDER_DATA_MAXSIZE which is defined in tst_net.sh according to
TST_IPV6. We can

1) overwrite NS_ICMP_SENDER_DATA_MAXSIZE="$NS_ICMPV6_SENDER_DATA_MAXSIZE"
2) check TST_IPV6 before running tst_net_parse_args and if set overwrite -6 flag

But both are quite ugly, thus unless you have better idea I merge this patchset.

Kind regards,
Petr

> > Kind regards,
> > Petr