[LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib
Petr Vorel
pvorel@suse.cz
Fri Aug 20 12:59:14 CEST 2021
Hi Joerg,
LGTM, good idea.
But I'd rename $LTP_IPC_PATH to $TST_IPC_PATH to follow conventions to new API
(There are also some LTP_* definitions in the legacy C API which were renamed as
TST_* in the new API).
> + if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "${LTP_IPC_PATH}" ]; then
nit (remove unnecessary {}):
if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "$TST_IPC_PATH" ]; then
> + rm ${LTP_IPC_PATH}
and here:
rm $TST_IPC_PATH
Kind regards,
Petr
More information about the ltp
mailing list