[LTP] [PATCH] epoll_creat01: Replace TST_PASS with TST_RET

Xie Ziyao ziyaoxie@outlook.com
Fri Aug 27 14:03:47 CEST 2021


Hi,

> In TST_EXP_FD(), the value of TST_RET is the returned fd, not TST_PASS.
>
> Fixes: 081f940b2df00 ("epoll_create: Add test for epoll_create01")
> Signed-off-by: Xie Ziyao <ziyaoxie@outlook.com>
> ---
>   testcases/kernel/syscalls/epoll_create/epoll_create01.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/epoll_create/epoll_create01.c b/testcases/kernel/syscalls/epoll_create/epoll_create01.c
> index 54fd0810d..29ac3763e 100644
> --- a/testcases/kernel/syscalls/epoll_create/epoll_create01.c
> +++ b/testcases/kernel/syscalls/epoll_create/epoll_create01.c
> @@ -26,9 +26,8 @@ static void run(unsigned int n)
>   {
>   	TST_EXP_FD(tst_syscall(__NR_epoll_create, tc[n]), "epoll_create(%d)", tc[n]);
>
> -	if (!TST_PASS)
> -		return;
> -	SAFE_CLOSE(TST_PASS);
> +	if (TST_RET)
> +		SAFE_CLOSE(TST_RET);

This patch fixes the incorrect use of TST_PASS in commit 081f940 
("epoll_create: Add test for epoll_create01"), which I noticed when 
reviewing the merged commit.

Sorry for this minor mistake.


>   }
>
>   static struct tst_test test = {
> --
> 2.25.1
>
>
-- 
Best Regards,
Xie Ziyao
E-mail: ziyaoxie@outlook.com



More information about the ltp mailing list