[LTP] [RFC PATCH] ltp-pan: Report failure if testcases failed to run

[Sagi Nakash]

Ping

On Sat, Nov 27, 2021, 14:16 Sagi Nakash <saginakash@gmail.com> wrote:

> In case a test fails to run in run_child() for some reason (signaled via
> SIGTERM/SIGTOP, execve() failure, etc.), runltp still reports success:
> "INFO: ltp-pan reported all tests PASS".
>
> Failed tests are reported via check_pids(), by checking their exit
> status, yet it doesn't catch tests which weren't able to run at all.
>
> exit_stat holds the exit status code: 0 in case of success in all tests,
> otherwise, the number of failed tests.
>
> Fix this by increasing exit_stat also when a test fails to run.
>
> Signed-off-by: Sagi Nakash <saginakash@gmail.com>
> ---
>  pan/ltp-pan.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
> index 0bdb51477..eff9a867d 100644
> --- a/pan/ltp-pan.c
> +++ b/pan/ltp-pan.c
> @@ -551,6 +551,8 @@ int main(int argc, char **argv)
>                                 ++num_active;
>                         if ((cpid != -1 || sequential) && starts > 0)
>                                 --starts;
> +                       if (cpid == -1 && track_exit_stats)
> +                               exit_stat++;
>
>                         if (sequential)
>                                 if (++c >= coll->cnt)
> --
> 2.25.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20211203/93e69ff5/attachment.htm>