[LTP] [PATCH 2/2] check: Add LTP-005 null termination check on test.tags

Cyril Hrubis chrubis@suse.cz
Mon Dec 6 16:49:23 CET 2021


Hi!
> This does not explicitly check for zero at the end of an array. For
> one thing the zero is implicit when one writes '{}'. We just get an
> empty expression list. When one writes '{NULL, 0}', we get an implicit

I would vote for dropping the part that checks for implicit cats so that
we unify all code on {} for sentinels. I guess that all we would have to
do is to drop the loop and only check if the list is empty.

Other than that the code looks good to me:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list