[LTP] [PATCH] syscalls/statx05, 07: Move e4crypt, exportfs to tst_test structure

xuyang2018.jy@fujitsu.com xuyang2018.jy@fujitsu.com
Tue Dec 7 02:44:26 CET 2021


Hi Cyril
> Hi!
>> --- a/testcases/kernel/syscalls/statx/statx05.c
>> +++ b/testcases/kernel/syscalls/statx/statx05.c
>> @@ -10,8 +10,6 @@
>>    * Test statx syscall with STATX_ATTR_ENCRYPTED flag, setting a key is required
>>    * for the file to be encrypted by the filesystem.
>>    *
>> - * e4crypt is used to set the encrypt flag (currently supported only by ext4).
>
> Maybe we should keep the info that it's currently supported on ext4 only
> with something as:
>
> * Encrypted files are currently supported by ext4 only.
It seems this message refers to e4crypt tools(like xfs filesystem 
xfs_io/xfs_quota command supports foreign mode that can support other 
filesystem.).

e4crypt tools may supports foreign mode in the feature. So I prefer to use
"Using e4crypt to encrypt files are currently supported by ext4 only" 
message.

Best Regards
Yang Xu
>
>
> Other than this it's obviously fine:
>
> Reviewed-by: Cyril Hrubis<chrubis@suse.cz>
>


More information about the ltp mailing list