[LTP] [PATCH v3 2/2] testcase: make use of needs_cmd version check

xuyang2018.jy@fujitsu.com xuyang2018.jy@fujitsu.com
Fri Dec 10 03:37:12 CET 2021


Hi Petr
> Hi Xu,
>
> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>
>>   testcases/kernel/syscalls/quotactl/quotactl04.c | 11 +----------
>>   testcases/kernel/syscalls/statx/statx05.c       | 13 ++-----------
>>   2 files changed, 3 insertions(+), 21 deletions(-)
>
> NOTE: you could also remove #include<stdio.h>  from both files,
> it was needed only for popen() pclose() and fscanf()
Good catch, I also remove useless tst_safe_stdio.h since we remove 
version check code. But statx05.c still use snprintf so I keep stdio.h 
in there.

I merged this patch, thanks for you and cyril's reivew.

Best Regards
Yang Xu
>
> Kind regards,
> Petr


More information about the ltp mailing list