[LTP] [PATCH v2 3/3] lib: Add support for debugging .all_filesystems

Petr Vorel pvorel@suse.cz
Wed Dec 15 10:28:12 CET 2021


Hi Cyril, Li,

> > > > +| 'LTP_SINGLE_FS_TYPE'  | Testing only specified filesystem instead
> > all
> > >                                          ^   ^
> > >                                        |   "specifies"
> > >                                        there should be comma or dash here

> > I meant "specific", i.e. Testing only specific filesystem instead all
> > supported,


> +1



> > but "Testing only - specifies filesystem instead all supported" makes more
> > sense.


> Hmm, I think it also makes sense to people who care about the
> only one filesystem on their product. So this should _NOT_ be limit
> for test/debug, because it can help to reduce testing time for specific
> requirements.

> Let's just provide a variable and leave the usage to users:).

Right :).
@Cyril: agree with "Testing only specific filesystem instead all supported" ?

> > > Other than that the rest looks fine, for the patchset:
> > > Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> > Thanks! Waiting for Li and others for input before merging it.


> Good work.
> Reviewed-by: Li Wang <liwang@redhat.com>
Thanks!

Kind regards,
Petr


More information about the ltp mailing list