[LTP] [PATCH v4] Refactoring dio_append.c using LTP API

Petr Vorel pvorel@suse.cz
Wed Dec 15 12:50:46 CET 2021


Hi,

...
> > > That's an O_DIRECT open() EINVAL probably means that O_DIRECT is not
> > > supported. Is your /tmp/ on tmpfs?
> > Yes. As we cannot use SAFE_OPEN() in io_read_eof() [1], there should be check
> > for errno I guess.

> Maybe it would be a bit cleaner to add a check that would attempt to
> open a dummy file in the test setup and exit the O_DIRECT tests before
> they attempt to fork children...
+1

Kind regards,
Petr


More information about the ltp mailing list