[LTP] [PATCH v5 4/4] zram/zram01.sh: replacing data stored in this disk with allocated for this disk

Petr Vorel pvorel@suse.cz
Tue Dec 21 09:41:21 CET 2021


Hi Xu,

> Hi Petr
> >> Before ltp commit 4372f7a2156 ("Fix compression ratio calculation in zram01")[1], we
> > nit: we can drop [1]
> >> used free -m changes to calculate the compression ratio.

> >> After the above patch, we used compr_data_size to calculate. kernel documentation[2] has
> > nit: I'd add link to the doc also in this commit message.
> I don't see the link on your ltp fork:
> https://github.com/pevik/ltp/tree/yang_xu/zram-swap.v5.fixes
I haven't fixed it there, I pushed it to verify there is no build failure.

> I have tried this branch and these change seems fine.
Yes, code should have my suggestions.

> I guess I don't need to send a v6 patch and you can merge it directly(by 
> removing [1][2] linke and adding fixes tag ). Is it right?
Ah, sure, go ahead and merge. I'm sorry to pick on details.

> ps: I want to add a fixes tag for pointing to commit 4372f7a2156 ("Fix 
> compression ratio calculation in zram01").
+1, thanks!

Kind regards,
Petr

> Best Regards
> Yang Xu


More information about the ltp mailing list