[LTP] [PATCH v2 1/1] tst_af_alg: Another fix for disabled weak cipher

[Petr Vorel]

Hi Eric,

> On Wed, Dec 22, 2021 at 06:01:37PM +0100, Petr Vorel wrote:
> > Hi Eric,

> > > On Mon, Dec 20, 2021 at 10:27:56PM +0100, Petr Vorel wrote:
> > > > tst_af_alg.c:84: TBROK: unexpected error binding AF_ALG socket to hash algorithm 'md5': ELIBBAD (80)

> > > This seems like a kernel bug; shouldn't the kernel report ENOENT for the
> > > algorithms that fips_enabled isn't allowing, just like other algorithms that
> > > aren't available?  Have you checked with linux-crypto@vger.kernel.org that the
> > > current behavior is actually intentional?
> > It reports ELIBBAD. Am I missing something?


> It does.  I am asking whether it should.  The purpose of LTP is to find kernel
> bugs; perhaps it found a bug here?

Well, if I understand mainline kernel code correctly, although crypto/testmgr.c
in alg_test() returns -EINVAL for non-fips allowed algorithms, but that means
failing crypto API test. And the API in crypto_alg_lookup() returns -ELIBBAD for failed test.

But I'll check it with Herbert Xu.

Kind regards,
Petr

> - Eric