[LTP] [PATCH v2 3/3] syscalls: Remove unused include <fcntl.h>

Petr Vorel pvorel@suse.cz
Wed Jan 13 11:02:05 CET 2021


Hi Xu,

> 于 2021/1/13 17:16, Xiao Yang 写道:
> > On 2021/1/13 15:51, Petr Vorel wrote:
> > > Tests should always use lapi/fcntl.h instead of<fcntl.h>  to fix
> > > possible missing definitions.

> > > But in this case removing include, because fanotify tests include
> > > <fcntl.h>  in lapi/fcntl.h (via fanotify.h) and
> > > {name_to,open_by}_handle_at tests include lapi/fcntl.h in
> > > lapi/name_to_handle_at.h.
> > Hi Petr,

> > This patchset looks good to me.
> > Reviewed-by: Xiao Yang<yangx.jy@cn.fujitsu.com>

> > Only one monir question:
> > Why do we remove<fcntl.h>  header for all fanotify tests?

> Sorry, correct one word(do =>don't)
Right :). That actually makes sense, thanks!
I'll merge it with this change.

Kind regards,
Petr


More information about the ltp mailing list