[LTP] Holidays and LTP release

Cyril Hrubis chrubis@suse.cz
Wed Jan 20 14:33:14 CET 2021


Hi!
> > do you mean something like this ?
> > But this change did not solve the problem (ioctl_sg01) i have reported.
> > 
> > diff --git a/lib/tst_memutils.c b/lib/tst_memutils.c
> > index f134d90c9..00bf45e9c 100644
> > --- a/lib/tst_memutils.c
> > +++ b/lib/tst_memutils.c
> > @@ -20,7 +20,7 @@ void tst_pollute_memory(size_t maxsize, int fillchar)
> >         struct sysinfo info;
> > 
> >         SAFE_SYSINFO(&info);
> > -       safety = 4096 * SAFE_SYSCONF(_SC_PAGESIZE) / info.mem_unit;
> > +       safety = 8192 * SAFE_SYSCONF(_SC_PAGESIZE) / info.mem_unit;
> 
> Actually Martin sugessted a different patch that chooses the margin to
> be the greater of 4096 pages or 64MB, which would effectivelly set the
> safety to "16384 * SAFE_SYSCONF(_SC_PAGESIZE) / info.mem_unit" on most
> systems.
> 
> Also I've been playing with a VM and I've been able to reproduce
> occasional failures with swap turned off and memory_overcommit set to 1
> that Martin's patch fixed for me.

And it looks like the patch for tst_memutils.c is the last one that
should be taken care of before the release.

It would be nice if you could check if that fixes your failures as well.

However it made the situation better, at least for me, so I will push it
tomorrow morning and proceed with the release.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list