[LTP] [PATCH v2 1/2] syscalls/sched_getparam{01, 02}: Convert to new API and cleanup

Xiao Yang ice_yangxiao@163.com
Sun Jan 31 08:51:35 CET 2021


On 1/29/21 9:21 PM, Cyril Hrubis wrote:
> Hi!
>> +		if (param.sched_priority) {
>> +			tst_res(TFAIL,
>> +				"sched_getparam(%d) got wrong sched_priority %d, expected 0",
>> +				pids[n], param.sched_priority);
>> +			exit(1);
> I do not think that we should do exit(1) here, since that would cause
> TBROK in the library when we reap the children. The failure is
> propagated by the tst_res(TFAIL, ...) here already.
>
> With the exit(1) replaced by exit(0):
>
> 	Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Hi Cyril,

Thanks for your comment.  Pushed with two minor changes:

Replaced exit(1) and updated description in sched_getparam01.

Best Regards,

Xiao Yang

>



More information about the ltp mailing list