[LTP] [PATCH 0/1] fs_bind: Convert to ltp tests

Richard Palethorpe rpalethorpe@suse.de
Tue Jul 6 11:45:56 CEST 2021


Hello Joerg,

Joerg Vehlow <lkml@jv-coder.de> writes:

> Hi everyone,
>
> I know this is a huge changeset, but there is not really a good way to         
> break it down into multiple commits. Every step in between would either
> lead to a broken test suite or a change, that is then changed again.
> So I made this one huge commit, that converts all of the tests of the     
> testsuite in one go.

It seems like there are no file renames (according to Git), but many
files are deleted and created. So you could split the commit into a
deletion patch and a creation patch.

I guess the deletion patch might have to remove some runtest file
entries temporarily? However I don't see a big problem with that.

>
> I added some minor bugfixes especially added umounts, because some where
> missing and some were redundant. I also dropped all useless output (bare ls).
>
> I may have overused EXPECT_PASS a bit here, but I think it does not do any harm,
> if all mounts are checked.
>
> Joerg


-- 
Thank you,
Richard.


More information about the ltp mailing list