[LTP] [PATCH] syscalls/fanotify: Fix running tests in a loop
Petr Vorel
pvorel@suse.cz
Thu Jul 15 09:08:15 CEST 2021
Hi Amir,
> Both fanotify19 and fanotify18 leaked fds when run in a loop.
> fanotify19 was not checking child process exit status correctly
> which resulted in random failures.
Thanks for a quick fix!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
FYI both fixes prolonged running for about 100% (comparing with runs on master
which don't fail). Of course, that's not a problem at all, it's just interesting
for me how simple closing of file descriptor can be expensive.
Kind regards,
Petr
# time ./fanotify19 -i40
Summary:
passed 360
failed 0
broken 0
skipped 0
warnings 0
real 0m0,871s
user 0m0,028s
sys 0m0,116s
vs.
Summary:
passed 360
failed 0
broken 0
skipped 0
warnings 0
real 0m0,387s
user 0m0,016s
sys 0m0,122s
# time ./fanotify19 -i10
Summary:
passed 160
failed 0
broken 0
skipped 0
warnings 0
real 0m0,436s
user 0m0,032s
sys 0m0,128s
vs.
Summary:
passed 160
failed 0
broken 0
skipped 0
warnings 0
real 0m0,876s
user 0m0,052s
sys 0m0,105s
More information about the ltp
mailing list