[LTP] [PATCH 4/4 v2] syscalls/fcntl: Replace TINFO with TPASS or TFAIL
Petr Vorel
pvorel@suse.cz
Mon Jun 7 16:32:50 CEST 2021
Hi Zhao, Cyril,
> Hi!
> > not sure if change to use goto satisfied Cyril's requirement:
> > we should rather skip the test in the main instead
> > as it was done in the original code as:
> > if (NO_NFS)
> > run_test(...);
> > else
> > tst_resm(TCONF, "Skipping mandatory locking on NFS");
> Yes I still think that the code looks better if we skip the test in the
> main here.
+1. Replacing int return with goto err for no reason is ugly.
Zhao, would you please send v3 with this fixed?
Kind regards,
Petr
More information about the ltp
mailing list