[LTP] [PATCH] icmp_rate_limit01: Require CONFIG_VETH

[Martin Doucha]

Hi,
looks good.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 15. 06. 21 9:51, Richard Palethorpe wrote:
> The test fails with TBROK if it can not create a virtual ethernet
> pair. So add it to the kconfigs.
> 
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
> 
> Just thinking about the config meta data and embedded users. Functions
> like tst_create_veth_pair could check needs_kconfigs for the required
> config and TBROK if it is not there.
> 
> Alternatively (or in addition to) static analyses can be used to check
> (or add) missing config.
> 
> In either case this may be wrong when a function is only used in a
> branch. OTOH then the test needs splitting otherwise the metadata
> can't be known ahead of execution.

I'll mention the need to check CONFIG_VETH in the docs.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic