[LTP] [PATCH 2/3] syscalls/sendfile: Convert sendfile06 to the new API

Petr Vorel pvorel@suse.cz
Thu Jun 17 22:06:29 CEST 2021


Hi Ziyao,

> 1. Convert sendfile06 to the new API with file descriptors instead
> of socket descriptors.
I wonder if this is ok, suppose yes, but better if other check.

> 2. Remove the support for UCLINUX.

LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

...
> +	TEST(sendfile(out_fd, in_fd, NULL, sb.st_size));
> +	after_pos = SAFE_LSEEK(in_fd, 0, SEEK_CUR);
> +
> +	if (TST_RET != sb.st_size)
nit: checkpatch.pl complains, it should be if (sb.st_size != TST_RET)
(can be fixed during merge)

Kind regards,
Petr


More information about the ltp mailing list