[LTP] [PATCH] tst_rtnetlink: pass error codes using rtnl_errno variable

Martin Doucha mdoucha@suse.cz
Tue Jun 22 18:17:37 CEST 2021


On 22. 06. 21 18:11, Richard Palethorpe wrote:
> Hello Martin,
> 
> Martin Doucha <mdoucha@suse.cz> writes:
>> +extern int rtnl_errno;
> 
> This is polluting the name space. I suppose it can be prepended
> with tst_, but does the test author need to see this? Or you could even
> just merge tst_netdevice and tst_rtnetlink.
> 
> Otherwise I think this approach is fine.

You're right, I should have prefixed it with tst_. I'll send v2 in a moment.

Yes, test authors will need to access this variable if they want to use
RTNL_CHECK_ACKS() or RTNL_SEND_VALIDATE() in their tests.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


More information about the ltp mailing list