[LTP] [PATCH v3 1/4] include/tst_pid.h: fix language typo (subtraction)
Petr Vorel
pvorel@suse.cz
Mon Jun 28 21:29:16 CEST 2021
> On 28/06/2021 16:49, Petr Vorel wrote:
> > Hi Krzysztof,
> >> /*
> >> - * Returns number of free pids by substarction of the number of pids
> >> + * Returns number of free pids by subtraction of the number of pids
> >> * currently used ('ps -eT') from max_pids
> > Because you change the description of this function in the next commit,
> > I'd just fix this simple typo in 2nd commit. But of course it's not wrong
> > (prevents keeping the fix even if we'd removed second commit).
> The commits should do only one thing (fix one bug, bring one feature if
> possible) and the next commit does not touch that line. There is no
> re-doing of the same change in next commit.
As I wrote in this case I wouldn't bother (with test rewrite to new API there
are much more changes in single commit), but sure you're right this is the best
practice which we follow.
Kind regards,
Petr
> Best regards,
> Krzysztof
More information about the ltp
mailing list