[LTP] [PATCH] clock_gettime04: print more info to help debugging

Viresh Kumar viresh.kumar@linaro.org
Mon Mar 8 12:14:47 CET 2021


On 08-03-21, 18:59, Li Wang wrote:
> Yes, but that's not harmful.

But is useless.

> If you remove all entries of varaints[] you can
> still get PASS from the test, that's something strange to us. So I just add
> this check there.

Yes, that would happen because we will not run the inner loop in that
case and even the condition you are adding will not run at all.

This wasn't designed to run with empty variants list and so we don't
verify that variants structure is empty or not and so it passes.

> No, that will only print the first entry instruct variants because you're
> using two iterations in the run(), the second loop 'j' is to traverse the
> variants[] actually.

Ahh, my bad. I didn't read the code properly. Sorry about that.

Now that I had a look again, with what you are adding here we will
start printing another line for each variant and it will be printed
just once at the beginning of the loop of 10000 iterations. Right ?

I am not sure how that will help you get more info out, to me it is
still very much unreadable. Can you show the final output as well ?

What about adding tv->desc to all the existing print messages instead
? Or maybe just the TFAIL ones? So we print everything in a single
line only ?

-- 
viresh


More information about the ltp mailing list