[LTP] [PATCH 2/6] fzsync: Reset delay bias

Richard Palethorpe rpalethorpe@suse.de
Mon Mar 8 15:50:15 CET 2021


Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> If the delay bias a preserved then it breaks tests which have multiple
>                     ^
> 		    is?

Yup, typo.

>
>> scenarios and/or use -i. The test author could reset it manually in
>> this case, but it's likely to be error prone.
>>
>> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
>
> Other than that this looks OK.
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>
>> ---
>>  include/tst_fuzzy_sync.h | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/include/tst_fuzzy_sync.h b/include/tst_fuzzy_sync.h
>> index 4141f5c64..b8841d96d 100644
>> --- a/include/tst_fuzzy_sync.h
>> +++ b/include/tst_fuzzy_sync.h
>> @@ -289,6 +289,7 @@ static void tst_fzsync_pair_reset(struct tst_fzsync_pair *pair,
>>  	tst_init_stat(&pair->diff_ab);
>>  	tst_init_stat(&pair->spins_avg);
>>  	pair->delay = 0;
>> +	pair->delay_bias = 0;
>>  	pair->sampling = pair->min_samples;
>>  
>>  	pair->exec_loop = 0;
>> -- 
>> 2.30.1
>> 
>> 
>> -- 
>> Mailing list info: https://lists.linux.it/listinfo/ltp


-- 
Thank you,
Richard.


More information about the ltp mailing list