[LTP] [PATCH] syscalls: Use anonymous .resource_files for docparse

Xiao Yang ice_yangxiao@163.com
Wed Mar 10 15:54:17 CET 2021


On 3/10/21 6:32 PM, Petr Vorel wrote:
> Hi,
>
>> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
>> -static const char *const resource_files[] = {
>> -	TEST_APP,
>> -	NULL,
>> -};
>> -
>>   static struct tst_test test = {
>>   	.test_all = verify_creat,
>>   	.needs_checkpoints = 1,
>>   	.forks_child = 1,
>> -	.resource_files = resource_files,
>> +	.resource_files = (const char *const []) {
>> +		TEST_APP,
> Don't we want to drop TEST_APP definition and use file directly?
> Having TEST_APP does not say much.

Hi Petr,


I can use file name directly in v2 patch.

Do you agree to use anonymous .resource_files for now? or is it better 
to keep it?


> Not sure how far we should go with moving everything into inline anonymous
> definitions (it'd be nice if docparse was able to just expand macros, but that
> would be way too slow).

I agree that expanding macros or structs is the nicer way but

we need to do some investigation about it.


Best Regards,

Xiao Yang

>
> Kind regards,
> Petr
>



More information about the ltp mailing list