[LTP] [PATCH 1/3] lib: Add proper filesystem skiplist

Petr Vorel pvorel@suse.cz
Wed Mar 10 16:39:25 CET 2021


Hi Cyril,

..
> > > +	for (i = 0; skiplist[i]; i++) {
> > > +		if (!strcmp(fs_type, skiplist[i])) {
> > > +			tst_res(TINFO,
> > It'd be nice if skipping message could be TCONF to avoid:
> > tst_supported_fs_types.c:57: TINFO: Skipping tmpfs as requested by the test
> > tst_test.c:1056: TCONF: Skipping due to unsupported filesystem

> > but understand why - it'd make code more complicated (has_kernel_support() which
> > is used in tst_fs_is_supported() should not emit TCONF).

> I can make a internal wrapper for the tst_fs_is_supported() that prints
> the TINFO message and use that in the tst_supported_fs_types, which
> would make it silent in the case it's called from the test library...

Up to you, not really that important to bother with it.

Kind regards,
Petr


More information about the ltp mailing list