[LTP] [PATCH 1/3] lib: Add proper filesystem skiplist

[Martin Doucha]

On 10. 03. 21 17:22, Cyril Hrubis wrote:
> Hi!
>>> +static int has_kernel_support(const char *fs_type, const char *const *skiplist)
>>>  {
>>>  	static int fuse_supported = -1;
>>>  	const char *tmpdir = getenv("TMPDIR");
>>>  	char buf[128];
>>>  	int ret;
>>>  
>>> +	if (tst_fs_in_skiplist(fs_type, skiplist))
>>> +		return 0;
>>> +
>>>  	if (!tmpdir)
>>>  		tmpdir = "/tmp";
>>>  
>>> @@ -84,26 +105,24 @@ static int has_kernel_support(const char *fs_type, int flags)
>>>  		return 0;
>>>  	}
>>>  
>>> -	if (flags & TST_FS_SKIP_FUSE) {
>>> -		tst_res(TINFO, "Skipping FUSE as requested by the test");
>>> +	if (tst_fs_in_skiplist("fuse", skiplist))
>>>  		return 0;
>>> -	}
>>>  
>>>  	tst_res(TINFO, "FUSE does support %s", fs_type);
>>>  	return 1;
>>>  }
>>
>> I don't think that has_kernel_support() should look at the skiplist at
>> all. The entire skiplist logic should be handled in
>> tst_get_supported_fs_types(). But has_kernel_support() could return
>> different (non-zero) values for native support and for FUSE support.
> 
> I do not agree, that would add more complexity to an internal function
> that is not exported outside the library.

Your patchset adds complexity to tst_fs_is_supported() which is a public
wrapper of has_kernel_support(), even though it's only used indirectly
in shell tests. Some tests might use that function directly in the
future so let's make the interface cleaner, not hairier.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic