[LTP] [PATCH] syscalls: Use anonymous .resource_files for docparse

Petr Vorel pvorel@suse.cz
Thu Mar 11 11:33:05 CET 2021


Hi,

...
> > Hi Petr,

> > I can use file name directly in v2 patch.
> OK. I'd like to know the others opinion (precedent).

> > Do you agree to use anonymous .resource_files for now? or is it better to
> > keep it?
> I guess yes, we've already started to use it.

> > > Not sure how far we should go with moving everything into inline anonymous
> > > definitions (it'd be nice if docparse was able to just expand macros, but that
> > > would be way too slow).

> > I agree that expanding macros or structs is the nicer way but

> > we need to do some investigation about it.
> gcc -E foo.c would do expansion for us. But not sure if it's worth of runtime.
> Because problem of missing definitions will be on other places and we don't want
> to get rid of definitions. e.g. I planned to add some tag definitions (for
> "linux-git", ...) as Martin Doucha suggested, but this would not work until
> we expand macros.

I was looking into the output of gcc -E but it brings other problems.
Wouldn't be better instead of patching like this to just replace docparse.c with
library support to test itself print it's description in json format
(e.g. --print-json opt)? I was thinking to use the same for shell tests docparse
(which aren't covered at all yet).

The downside would be that generation would be much slower and require native
build.

> Kind regards,
> Petr

> > Best Regards,

> > Xiao Yang


More information about the ltp mailing list