[LTP] [PATCH 1/2] Add FS quota availability check functions

Petr Vorel pvorel@suse.cz
Fri Mar 12 18:37:50 CET 2021


Hi Martin,

> >> +	TEST(quotactl(QCMD(Q_QUOTAON, USRQUOTA), device, format, quotafile));
> > Actually, there is a warning:
> > tst_supported_fs_types.c: In function ‘tst_check_quota_support’:
> > tst_supported_fs_types.c:117:59: warning: passing argument 4 of ‘quotactl’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> >   117 |  TEST(quotactl(QCMD(Q_QUOTAON, USRQUOTA), device, format, quotafile));

> > Would you prefer to cast to char *, or just change function parameter to char *?

> Thanks for catching this. Passing string literals to the function
> directly is technically wrong so I'll drop the const and fix the tests
> to allocate a buffer for quotafile paths. I'll resubmit on Monday.
Thanks a lot!

Kind regards,
Petr


More information about the ltp mailing list