[LTP] [PATCH v5 7/7] madvise06: Convert to new CGroups API

Cyril Hrubis chrubis@suse.cz
Mon May 3 15:28:46 CEST 2021


Hi!
> -/*
> - * DESCRIPTION
> +/*\
> + * [DESCRIPTION]

This should be [Description] now.

>   *
>   *   Page fault occurs in spite that madvise(WILLNEED) system call is called
>   *   to prefetch the page. This issue is reproduced by running a program
> @@ -36,13 +36,14 @@
>   *   else unexpected, but irrelevant procedure, registers a fault to
>   *   our process.
>   *
> - */
> +\*/

And this should be just */.

Also there are spaces prepended to the description which I guess may end
up as a <pre> block markup. Can we please fix that as well?

Also if we are pedantic this go in as a separate patch.


The actuall changes to the code looks good to me, nice cleanup.

With the description comment sorted out:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list