[LTP] [PATCH 2/2] tst_test: using SIGTERM to terminate process

Li Wang liwang@redhat.com
Wed May 19 10:52:57 CEST 2021


Hi Joerg,

> This works fine.
> +Reviewed-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
> after my remarks are resolved.

Thanks for the above comments, I will fix them all in patch V2.

> But one more strange thing here.
> I wonder why this even works. $pid is used in _tst_kill_test and defined
> in _tst_setup_timer as a local variable.
> It looks like it is inherited through the call chain and since it is
> copied to the background process, it cannot be manipulated by the tests.
> Still I would vote for changing this at some point, because it is highly
> confusing.

+1

Agree, I look at it a while and seems a local variable can only be
visible in the sub-function/call-chain of SHELL.

But I vote to fix the problem in a separate patch, it'd be appreciated
if you help make the patch.

-- 
Regards,
Li Wang



More information about the ltp mailing list