[LTP] [PATCH 6/6] sched/cgroup: Add cfs_bandwidth01
Cyril Hrubis
chrubis@suse.cz
Tue May 25 11:06:27 CEST 2021
Hi!
> I think maybe this API makes a fundamental mistake of mixing memory/object
> management with actual creation and deletion of CGroups. OTOH that is
> not really clear either.
>
> But if a child process starts deleting CGroups, which might be a
> reasonable thing to do, then we will get a mismatch between child and
> parent. Then the cleanup will be wrong.
Good point. I guess that we can make up rules that would make sure we do
not run cleanup both in the parent and child, but that would probably
overcomplicate the library.
> Also any kind of linked list or array implementation uses more lines of
> code than the cleanup function and more complex for sure... even if we
> have 10 test cases like this is it really work saving a few lines in
> each case?
>
> I don't know. But I think we need to see a few more cases.
Makes sense.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list