[LTP] [PATCH v2 7/7] docparse: Split into metadata and docparse

Cyril Hrubis chrubis@suse.cz
Tue Nov 2 17:04:17 CET 2021


Hi!
> > > ltp.git/metadata $ make
> > > HOSTCC metadata/metaparse
> > > ltp.git/metadata/parse.sh > ltp.json
> > > ltp.git/metadata/parse.sh: line 33: ltp.git/metadata/../docparse/docparse: No such file or directory
> > > # => OK let's go to docparse and make first
> 
> > The docparse build should be triggered from the metadata directory,
> > since the ltp.json has to be generated first.
> 
> > But I have forgotten to update the parse.sh script. Have you seen the
> > reply to this patch?
> 
> I see, thx!

Also looking at the Makefile it may not work with out-of-tree build, so
we may need this as well:

diff --git a/metadata/Makefile b/metadata/Makefile
index 76a3aed94..9b88d8302 100644
--- a/metadata/Makefile
+++ b/metadata/Makefile
@@ -17,10 +17,10 @@ ltp.json: metaparse

 docparse: ltp.json
 ifeq ($(WITH_METADATA),yes)
-       $(MAKE) -C ../docparse/
+       $(MAKE) -C $(top_srcdir)/docparse/
 endif

 test:
-       $(MAKE) -C tests/ test
+       $(MAKE) -C $(abs_srcdir)/tests/ test

 include $(top_srcdir)/include/mk/generic_leaf_target.mk


-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list