[LTP] [PATCH v3 1/3] lib: adding .supported_archs field in tst_test structure

[Li Wang]

> > diff --git a/include/tst_arch.h b/include/tst_arch.h
> > new file mode 100644
> > index 000000000..784c3093b
> > --- /dev/null
> > +++ b/include/tst_arch.h
> > @@ -0,0 +1,39 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later
> > + * Copyright (c) 2021 Li Wang <liwang@redhat.com>
> > + */
> > +
> > +#ifndef TST_ARCH_H__
> > +#define TST_ARCH_H__
> > +
> > +enum tst_arch_type {
> > +     TST_I386,
> > +     TST_X86,
>
> Why do we have both i386 and X86 here? Isn't __i386__ synonymous for
> __x86__ does gcc even define __x86__?
>

My fault, I just copy that from testcase defines and didn't check
if __x86__ validatable or not.

>
> I doubt that we care about the differencies between i386, i586 and i686
> at all. I would just keep TST_X86 in the list for any 32bit intel
> compatible hardware.
>

I prefer to only keep TST_I386 and TST_X86_64 for use. Becuase
so far I didn't see there is a requirement on i[4|5|6]86 in LTP at all.
And, we can add that if we really need it in the future.

The rest of the comments looks good, thanks.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20211109/dfe1c404/attachment.htm>