[LTP] [PATCH 1/4] posix/conformance/interfaces/fork/7-1: Fix test

[Joerg Vehlow]

Hi Cytil,

On 11/22/2021 10:41 AM, Cyril Hrubis wrote:
> Hi!
>> -static void read_catalog(nl_catd cat, char *who)
>> +static int read_catalog(nl_catd cat)
>>   {
>> +	static const char *notfound = "not found";
> Why static here?
Right, could be dropped. It doesn't really make a difference, but 
doesn't hurt either.
Remove it if you like.
>
>>   	char *msg = NULL;
>>   	int i, j;
>>   
>> -#if VERBOSE > 0
>> -	output("Reading the message catalog from %s...\n", who);
>> -#endif
>> -
>> -	errno = 0;
>> -
>> -	for (i = 1; i <= 2; i++) {
>> +	for (i = 1; i <= 3; i++) {
> Actually this change makes the test fail for me since there is no set 3.
>
> Have you modified this to check if the test fails and then forget to
> change it back?
Yes sorry, that is exactly what happened...
>
>
> Other than these two the changes looks good to me. If you agreen I can
> fix the two small issues before pushing it to the repo.
Perfect, thanks

Joerg