[LTP] [PATCH v2 3/3] Add test for NFS directory listing regression

Martin Doucha mdoucha@suse.cz
Wed Nov 24 10:27:23 CET 2021


On 23. 11. 21 20:40, Petr Vorel wrote:
> If you agree, I suggest to merge it with these changes:
> 
> diff --git testcases/network/nfs/nfs_stress/nfs07.sh testcases/network/nfs/nfs_stress/nfs07.sh
> index 2c04746fa..e44573405 100755
> --- testcases/network/nfs/nfs_stress/nfs07.sh
> +++ testcases/network/nfs/nfs_stress/nfs07.sh
> @@ -26,7 +26,7 @@ TST_USAGE="show_usage"
>  show_usage()
>  {
>  	nfs_usage
> -	echo "-n x    Create x files and x directories, default is 5000"
> +	echo "-n x    Create x files and x directories, default is $FILE_COUNT"
>  }

If you run `nfs07.sh -hn 123`, your version will print that the default
is 123.

>  
>  do_setup()
> @@ -45,7 +45,7 @@ do_test()
>  {
>  	local count
>  
> -	# Pass the list of files through `sort -u` in case `ls` doesn't fitler
> +	# Pass the list of files through `sort -u` in case `ls` doesn't filter
>  	# out potential duplicate filenames returned by buggy NFS
>  	count=`ls | grep '^file' | sort -u | wc -l`
>  
> @@ -61,7 +61,7 @@ do_test()
>  		return
>  	fi
>  
> -	tst_res TPASS "All files and directories were correctly listed"
> +	tst_res TPASS "All $FILE_COUNT files and directories were correctly listed"
>  }

That would make the line over 80 characters and the number isn't that
important. Let's fix just the "fitler" typo.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


More information about the ltp mailing list