[LTP] [RFC] Using shellcheck for shell make check

Cyril Hrubis chrubis@suse.cz
Mon Nov 29 12:54:29 CET 2021


Hi!
> checkbashisms does not detect all things: e.g. not catching {1..$FILE_COUNT}
> [1]. Maybe we should reconsider using *also* shellcheck as Joerg suggested
> (keep checkbashisms).
> 
> I don't like shellcheck output, but it can detects errors checkbashisms cannot
> detect (checkbashisms is regexp based, but shellcheck IMHO evaluates the code).
> Also it's configurable, thus ve could disable check we don't like or enable only
> what we want to check. Or we can run just --severity=warning or
> --severity=error. If you're not against it, I can have look into this.

Sounds good, the more automated checks we have the less we will spend on
review...

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list