[LTP] [PATCH v4 1/1] creat09: Run on all_filesystems

[Martin Doucha]

Hello,
looks good to me.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 15. 10. 21 10:38, Petr Vorel wrote:
> To make sure bug on XFS is detected on systems which use it.
> 
> Due setgid is test problematic on Microsoft filesystems:
> 
> creat09.c:81: TBROK: ntfs: Setgid bit not set
> creat09.c:76: TBROK: chown(exfat,65533,4) failed: EPERM (1)
> creat09.c:76: TBROK: chown(vfat,65533,4) failed: EPERM (1)
> 
> thus they're disabled.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> changes v3->v4:
> * remove useless .needs_tmpdir
> 
> changes v2->v3:
> * add missing dir separator /
> * remove unused SAFE_CHDIR() (was needed due missing /)
> * remove unused <stdio.h>
> 
>  testcases/kernel/syscalls/creat/creat09.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
> index 681b80c7d..bed7bddb0 100644
> --- a/testcases/kernel/syscalls/creat/creat09.c
> +++ b/testcases/kernel/syscalls/creat/creat09.c
> @@ -39,7 +39,8 @@
>  #define MODE_RWX        0777
>  #define MODE_SGID       (S_ISGID|0777)
>  
> -#define WORKDIR		"testdir"
> +#define MNTPOINT	"mntpoint"
> +#define WORKDIR		MNTPOINT "/testdir"
>  #define CREAT_FILE	WORKDIR "/creat.tmp"
>  #define OPEN_FILE	WORKDIR "/open.tmp"
>  
> @@ -118,7 +119,15 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.cleanup = cleanup,
>  	.needs_root = 1,
> -	.needs_tmpdir = 1,
> +	.all_filesystems = 1,
> +	.mount_device = 1,
> +	.mntpoint = MNTPOINT,
> +	.skip_filesystems = (const char*[]) {
> +		"exfat",
> +		"ntfs",
> +		"vfat",
> +		NULL
> +	},
>  	.tags = (const struct tst_tag[]) {
>  		{"linux-git", "0fa3ecd87848"},
>  		{"CVE", "2018-13405"},
> 


-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic