[LTP] [PATCH v1 04/11] syscalls/quotactl[3, 5, 7]: Add docparse formatting

Cyril Hrubis chrubis@suse.cz
Tue Oct 26 16:05:18 CEST 2021


Hi!
> -/*
> - * Test Name: quotactl03
> +/*\
> + * [Description]
>   *
> - * Description:
>   * quotactl(2) with XGETNEXTQUOTA looks for the next active quota for an user
>   * equal or higher to a given ID, in this test the ID is specified to a value
>   * close to UINT_MAX(max value of unsigned int). When reaching the upper limit
> @@ -16,11 +15,11 @@
>   *
>   * This kernel bug of xfs has been fixed in:
>   *
> - * commit 657bdfb7f5e68ca5e2ed009ab473c429b0d6af85
> - * Author: Eric Sandeen <sandeen@redhat.com>
> - * Date:   Tue Jan 17 11:43:38 2017 -0800
> + *  commit 657bdfb7f5e68ca5e2ed009ab473c429b0d6af85
> + *  Author: Eric Sandeen <sandeen@redhat.com>
> + *  Date:   Tue Jan 17 11:43:38 2017 -0800
>   *
> - *     xfs: don't wrap ID in xfs_dq_get_next_id
> + *  xfs: don't wrap ID in xfs_dq_get_next_id

The commit hash of this fix should also go into the tags in the tst_test
structure.

>   */
>  
>  #define _GNU_SOURCE
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl05.c b/testcases/kernel/syscalls/quotactl/quotactl05.c
> index e811e47a4..fbc7f5924 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl05.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl05.c
> @@ -2,19 +2,28 @@
>  /*
>   * Copyright (c) 2019 FUJITSU LIMITED. All rights reserved.
>   * Author: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This testcase checks basic flags of quotactl(2) for project on an XFS filesystem:
>   *
> - * This testcase checks basic flags of quotactl(2) for project on an XFS file
> - * system:
>   * 1) quotactl(2) succeeds to turn off xfs quota and get xfs quota off status
>   *    for project.
> + *
>   * 2) quotactl(2) succeeds to turn on xfs quota and get xfs quota on status
>   *    for project.
> + *
>   * 3) quotactl(2) succeeds to set and use Q_XGETQUOTA to get xfs disk quota
>   *    limits for project.
> + *
>   * 4) quotactl(2) succeeds to set and use Q_XGETNEXTQUOTA to get xfs disk
>   *    quota limits Cgreater than or equal to ID for project.
> + *
>   * 5) quotactl(2) succeeds to turn off xfs quota and get xfs quota off statv
>   *    for project.
> + *
>   * 6) quotactl(2) succeeds to turn on xfs quota and get xfs quota on statv
>   *    for project.
>   */

Here as well, the list should be fixed to render as a list.

> diff --git a/testcases/kernel/syscalls/quotactl/quotactl07.c b/testcases/kernel/syscalls/quotactl/quotactl07.c
> index db477589b..a55416f0e 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl07.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl07.c
> @@ -2,6 +2,10 @@
>  /*
>   * Copyright (c) 2019 FUJITSU LIMITED. All rights reserved.
>   * Author: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> + */
> +
> +/*\
> + * [Description]
>   *
>   * This is a regresstion test for kernel commit 3dd4d40b4208
>   * ("xfs: Sanity check flags of Q_XQUOTARM call").
> -- 
> 2.23.0
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list