[LTP] [PATCH v1 08/11] syscalls/quotaclt02, 5: Add quotactl_fd test variant

[Cyril Hrubis]

Hi!
> @@ -166,9 +174,11 @@ static struct tst_test test = {
>  	.tcnt = ARRAY_SIZE(tcases),
>  	.mount_device = 1,
>  	.dev_fs_type = "xfs",
> -	.mntpoint = mntpoint,
> +	.mntpoint = MNTPOINT,
>  	.mnt_data = "usrquota,grpquota",
>  	.setup = setup,
> +	.cleanup = cleanup,
> +	.test_variants = 2,

It may be a slightly cleaner to #define QUOTACTL_VARIANTS 2 in the
quotactl_var.h and use it here.

>  };
>  #else
>  	TST_TEST_TCONF("System doesn't have <xfs/xqm.h>");
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl02.h b/testcases/kernel/syscalls/quotactl/quotactl02.h
> index 37f3d7eb7..5b7c5ab32 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl02.h
> +++ b/testcases/kernel/syscalls/quotactl/quotactl02.h
> @@ -14,18 +14,20 @@
>  #include <stdio.h>
>  #include "tst_test.h"
>  #include "lapi/quotactl.h"
> +#include "quotactl_var.h"

Here as well, no need to include the "lapi/quotactl.h" anymore.


Other than that this patch looks good.

-- 
Cyril Hrubis
chrubis@suse.cz