[LTP] [PATCH 4/4] link/link07: Convert to new API
tangmeng
tangmeng@uniontech.com
Fri Oct 29 10:05:27 CEST 2021
Signed-off-by: tangmeng <tangmeng@uniontech.com>
---
testcases/kernel/syscalls/link/link07.c | 104 +++++-------------------
1 file changed, 20 insertions(+), 84 deletions(-)
diff --git a/testcases/kernel/syscalls/link/link07.c b/testcases/kernel/syscalls/link/link07.c
index 09743b59c..e166fe6e8 100644
--- a/testcases/kernel/syscalls/link/link07.c
+++ b/testcases/kernel/syscalls/link/link07.c
@@ -1,42 +1,20 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) Bull S.A. 2001
* Copyright (c) International Business Machines Corp., 2001
* 06/2002 Ported by Jacky Malcles
* Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
- * the GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
-/*
+/*\
+ * [Description]
+ *
* Verify that, link() fails with -1 and sets errno to EACCES when one of the
* directories in oldpath or newpath did not allow search (execute) permission.
*/
-#include <stdio.h>
-#include <stdlib.h>
-#include <unistd.h>
-#include <fcntl.h>
-#include <errno.h>
-#include <string.h>
-#include <signal.h>
-#include <sys/types.h>
-#include <sys/stat.h>
#include <pwd.h>
-
-#include "test.h"
-#include "safe_macros.h"
+#include "tst_test.h"
#define MODE_TO S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IXGRP|S_IXOTH|S_IROTH|S_IWOTH
#define MODE_TE S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IROTH|S_IWOTH
@@ -45,74 +23,32 @@
#define TEST_FILE2 "testdir_1/tfile_2"
#define NEW_TEST_FILE2 "testdir_1/new_tfile_2"
-static void setup(void);
-static void cleanup(void);
-
-char *TCID = "link07";
-int TST_TOTAL = 1;
-
-int main(int ac, char **av)
+static void verify_link(void)
{
- int lc;
-
- tst_parse_opts(ac, av, NULL, NULL);
-
- setup();
-
- for (lc = 0; TEST_LOOPING(lc); lc++) {
- tst_count = 0;
-
- TEST(link(TEST_FILE2, NEW_TEST_FILE2));
-
- /* Check return code from link(2) */
- if (TEST_RETURN != -1) {
- tst_resm(TFAIL | TTERRNO, "link() returned %ld, "
- "expected -1, errno=%d", TEST_RETURN, EACCES);
- } else {
- if (TEST_ERRNO == EACCES) {
- tst_resm(TPASS | TTERRNO,
- "link() fails with expected error");
- } else {
- tst_resm(TFAIL | TTERRNO, "link() failed"
- ", expected errno=%d (EACCES)",
- EACCES);
- }
- }
- }
-
- cleanup();
- tst_exit();
+ TST_EXP_FAIL(link(TEST_FILE2, NEW_TEST_FILE2), EACCES,
+ "link(%s, %s)", TEST_FILE2, NEW_TEST_FILE2);
}
static void setup(void)
{
struct passwd *nobody_pwd;
- tst_sig(NOFORK, DEF_HANDLER, cleanup);
-
- tst_require_root();
-
- TEST_PAUSE;
-
- tst_tmpdir();
-
/* Modify mode permissions on test directory */
- SAFE_CHMOD(cleanup, ".", MODE_TO);
+ SAFE_CHMOD(".", MODE_TO);
- SAFE_MKDIR(cleanup, DIR_TEMP, MODE_RWX);
- SAFE_TOUCH(cleanup, TEST_FILE2, 0666, NULL);
+ SAFE_MKDIR(DIR_TEMP, MODE_RWX);
+ SAFE_TOUCH(TEST_FILE2, 0666, NULL);
/* Modify mode permissions on test directory - test conditions */
- SAFE_CHMOD(cleanup, DIR_TEMP, MODE_TE);
+ SAFE_CHMOD(DIR_TEMP, MODE_TE);
- nobody_pwd = SAFE_GETPWNAM(cleanup, "nobody");
- SAFE_SETEUID(cleanup, nobody_pwd->pw_uid);
+ nobody_pwd = SAFE_GETPWNAM("nobody");
+ SAFE_SETEUID(nobody_pwd->pw_uid);
}
-static void cleanup(void)
-{
- if (seteuid(0))
- tst_resm(TWARN | TERRNO, "seteuid(o) failed");
-
- tst_rmdir();
-}
+static struct tst_test test = {
+ .test_all = verify_link,
+ .setup = setup,
+ .needs_tmpdir = 1,
+ .needs_root = 1,
+};
--
2.20.1
More information about the ltp
mailing list