[LTP] [PATCH 8/8] syscalls/setresuid03: Convert to new API
Martin Doucha
mdoucha@suse.cz
Thu Sep 9 17:51:26 CEST 2021
The original test looks up specific usernames which may not exist on some
systems. Use any two non-root UIDs instead.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
.../kernel/syscalls/setresuid/setresuid03.c | 266 ++++--------------
1 file changed, 53 insertions(+), 213 deletions(-)
diff --git a/testcases/kernel/syscalls/setresuid/setresuid03.c b/testcases/kernel/syscalls/setresuid/setresuid03.c
index ea06e02bf..f2ad75b13 100644
--- a/testcases/kernel/syscalls/setresuid/setresuid03.c
+++ b/testcases/kernel/syscalls/setresuid/setresuid03.c
@@ -1,245 +1,85 @@
+// SPDX-License-Identifier: GPL-2.0-only
/*
- *
* Copyright (c) International Business Machines Corp., 2001
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
- * the GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ * 07/2001 ported by John George
+ * Copyright (C) 2021 SUSE LLC <mdoucha@suse.cz>
*/
-/*
- * NAME
- * setresuid03.c
- *
- * DESCRIPTION
- * Test that the setresuid system call sets the proper errno
- * values when a non-root user attempts to change the real, effective or
- * saved uid to a value other than one of the current uid, the current
- * effective uid of the current saved uid. Also verify that setresuid
- * fails if an invalid uid value is given.
+/*\
+ * [Description]
*
- * ALGORITHM
- *
- * Setup:
- * Setup signal handling
- * Get user information.
- * Pause for SIGUSER1 if option specified.
- *
- * Setup test values.
- * Loop if the proper options are given.
- * For each test set execute the system call
- * Check that we received the expected result.
- * Verify that the uid, euid and suid values are still correct.
- * Cleanup:
- * Print errno log and/or timing stats if option given.
- *
- * USAGE: <for command-line>
- * setresuid03 [-c n] [-f] [-i n] [-I x] [-P x] [-t]
- * where, -c n : Run n copies concurrently.
- * -e : Turn on errno logging.
- * -f : Turn off functionality Testing.
- * -i n : Execute test n times.
- * -I x : Execute test for x seconds.
- * -P x : Pause for x seconds between iterations.
- * -t : Turn on syscall timing.
- *
- * History
- * 07/2001 John George
- * -Ported
- *
- * Restrictions
- * This test must be run by root.
- * nobody and bin must be a valid users.
+ * Test that the setresuid system call sets the proper errno values when
+ * a non-root user attempts to change the real, effective or saved uid
+ * to a value other than one of the current uid, the current effective uid
+ * or the current saved uid.
*/
-#define _GNU_SOURCE 1
-#include <pwd.h>
-#include <stdlib.h>
-#include "test.h"
-#include <errno.h>
-#include <sys/wait.h>
-
-#include <compat_16.h>
+#include "tst_test.h"
+#include "tst_uid.h"
+#include "compat_tst_16.h"
-TCID_DEFINE(setresuid03);
+static uid_t root_uid, main_uid, other_uid, neg_one = -1;
-uid_t neg_one = -1;
-
-/* flag to tell parent if child passed or failed. */
-int flag = 0;
-
-uid_t root_pw_uid, nobody_pw_uid, bin_pw_uid;
-char user1name[] = "nobody";
-char user2name[] = "bin";
-char rootname[] = "root";
-
-struct passwd nobody, bin, root;
-
-/*
- * The following structure contains all test data. Each structure in the array
- * is used for a separate test. The tests are executed in the for loop below.
- */
-
-struct test_data_t {
+static struct test_data_t {
uid_t *real_uid;
uid_t *eff_uid;
uid_t *sav_uid;
int exp_errno;
- struct passwd *exp_real_usr;
- struct passwd *exp_eff_usr;
- struct passwd *exp_sav_usr;
+ uid_t *exp_real_uid;
+ uid_t *exp_eff_uid;
+ uid_t *exp_sav_uid;
char *test_msg;
} test_data[] = {
- {
- &nobody_pw_uid, &neg_one, &neg_one, EPERM, &root, &bin, &bin,
- "After setresuid(root, -1, -1),"}, {
- &neg_one, &neg_one, &nobody_pw_uid, EPERM, &root, &bin, &bin,
- "After setresuid(-1, -1, bin),"}, {
- &neg_one, &nobody_pw_uid, &neg_one, EPERM, &root, &bin, &bin,
- "After setresuid(-1, -1, bin),"}
+ {&other_uid, &neg_one, &neg_one, EPERM, &root_uid, &main_uid,
+ &main_uid, "setresuid(other, -1, -1)"},
+ {&neg_one, &neg_one, &other_uid, EPERM, &root_uid, &main_uid,
+ &main_uid, "setresuid(-1, -1, other)"},
+ {&neg_one, &other_uid, &neg_one, EPERM, &root_uid, &main_uid,
+ &main_uid, "setresuid(-1, other, -1)"}
};
-int TST_TOTAL = sizeof(test_data) / sizeof(test_data[0]);
-
-void setup(void);
-void cleanup(void);
-
-void
-uid_verify(struct passwd *ru, struct passwd *eu, struct passwd *su, char *);
-
-int main(int ac, char **av)
+static void setup(void)
{
- int lc;
-
- tst_parse_opts(ac, av, NULL, NULL);
+ uid_t test_users[2];
- setup();
+ root_uid = getuid();
+ tst_get_uids(test_users, 0, 2);
+ main_uid = test_users[0];
+ other_uid = test_users[1];
- for (lc = 0; TEST_LOOPING(lc); lc++) {
- int i, pid;
+ UID16_CHECK(root_uid, setresuid);
+ UID16_CHECK(main_uid, setresuid);
+ UID16_CHECK(other_uid, setresuid);
- /* reset tst_count in case we are looping */
- tst_count = 0;
-
- /* set the appropriate ownership values */
- if (setresuid(root_pw_uid, bin_pw_uid, bin_pw_uid)
- == -1) {
- tst_brkm(TFAIL, cleanup, "Initial setresuid failed");
- }
-
- if ((pid = FORK_OR_VFORK()) == -1) {
- tst_brkm(TBROK, cleanup, "fork failed");
- } else if (pid == 0) { /* child */
-
- for (i = 0; i < TST_TOTAL; i++) {
-
- /* Set the real, effective or saved user id */
- TEST(SETRESUID(NULL, *test_data[i].real_uid,
- *test_data[i].eff_uid,
- *test_data[i].sav_uid));
-
- if (TEST_RETURN == -1 && TEST_ERRNO ==
- test_data[i].exp_errno) {
- tst_resm(TPASS, "setresuid(%d, %d, %d) "
- "failed as expected.",
- *test_data[i].real_uid,
- *test_data[i].eff_uid,
- *test_data[i].sav_uid);
- } else {
- tst_resm(TFAIL, "setresuid(%d, %d, %d) "
- "did not fail as expected.",
- *test_data[i].real_uid,
- *test_data[i].eff_uid,
- *test_data[i].sav_uid);
- flag = -1;
- }
-
- uid_verify(test_data[i].exp_real_usr,
- test_data[i].exp_eff_usr,
- test_data[i].exp_sav_usr,
- test_data[i].test_msg);
- }
- exit(flag);
- } else { /* parent */
- tst_record_childstatus(cleanup, pid);
- }
- }
- cleanup();
- tst_exit();
+ SAFE_SETRESUID(root_uid, main_uid, main_uid);
}
-/*
- * setup()
- * performs all ONE TIME setup for this test
- */
-void setup(void)
+static void run(unsigned int n)
{
- tst_require_root();
+ const struct test_data_t *tc = test_data + n;
- tst_sig(FORK, DEF_HANDLER, cleanup);
+ TEST(SETRESUID(*tc->real_uid, *tc->eff_uid, *tc->sav_uid));
- if (getpwnam("nobody") == NULL) {
- tst_brkm(TBROK, NULL, "nobody must be a valid user.");
+ if (TST_RET != -1) {
+ tst_res(TFAIL | TTERRNO, "%s returned unexpected value %ld",
+ tc->test_msg, TST_RET);
+ return;
}
- if (getpwnam("bin") == NULL) {
- tst_brkm(TBROK, NULL, "bin must be a valid user.");
+ if (TST_ERR != tc->exp_errno) {
+ tst_res(TFAIL | TTERRNO, "%s returned unexpected error",
+ tc->test_msg);
+ return;
}
- root = *(getpwnam("root"));
- UID16_CHECK((root_pw_uid = root.pw_uid), "setresuid", cleanup)
-
- nobody = *(getpwnam("nobody"));
- UID16_CHECK((nobody_pw_uid = nobody.pw_uid), "setresuid", cleanup)
-
- bin = *(getpwnam("bin"));
- UID16_CHECK((bin_pw_uid = bin.pw_uid), "setresuid", cleanup)
-
- /* Pause if that option was specified
- * TEST_PAUSE contains the code to fork the test with the -i option.
- * You want to make sure you do this before you create your temporary
- * directory.
- */
- TEST_PAUSE;
+ if (tst_check_resuid(tc->test_msg, *tc->exp_real_uid, *tc->exp_eff_uid,
+ *tc->exp_sav_uid))
+ tst_res(TPASS | TTERRNO, "%s failed as expected", tc->test_msg);
}
-/*
- * cleanup()
- * performs all ONE TIME cleanup for this test at
- * completion or premature exit
- */
-void cleanup(void)
-{
-
-}
-
-void
-uid_verify(struct passwd *ru, struct passwd *eu, struct passwd *su, char *when)
-{
- uid_t cur_ru, cur_eu, cur_su;
- if (getresuid(&cur_ru, &cur_eu, &cur_su) != 0) {
- flag = -1;
- tst_brkm(TBROK, cleanup, "Set getresuid() failed");
- }
- if ((cur_ru != ru->pw_uid) || (cur_eu != eu->pw_uid) || (cur_su !=
- su->pw_uid)) {
- tst_resm(TFAIL, "ERROR: %s real uid = %d; effective uid = %d; "
- "saved uid = %d", when, cur_ru, cur_eu, cur_su);
- tst_resm(TINFO, "Expected: real uid = %d, effective uid = %d "
- "saved uid = %d", ru->pw_uid, eu->pw_uid, su->pw_uid);
- flag = -1;
- } else {
- tst_resm(TINFO, "real uid = %d, effective uid = %d, and "
- "saved uid = %d as expected", cur_ru, cur_eu, cur_su);
- }
-}
+static struct tst_test test = {
+ .test = run,
+ .tcnt = ARRAY_SIZE(test_data),
+ .setup = setup,
+ .needs_root = 1,
+};
--
2.33.0
More information about the ltp
mailing list